[v23.2.x] rpk/bugfix: enable back setting tls struct values in set commands #13382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug introduced in 23.2 that made setting a TLS struct value impossible via set commands (rpk profile set, rpk redpanda config set). We were just checking for the empty/boolean case. (cherry picked from commit f8d04d5)
gene-redpanda
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual Backport of #13343
There was a bug introduced in 23.2 that made
setting a TLS struct value impossible via set
commands (rpk profile set, rpk redpanda config set). We were just checking for the empty/boolean case.
(cherry picked from commit f8d04d5)
Fixes #13378
Backports Required
Release Notes
Bug Fixes