Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: enable crash_loop_limit by default #13431

Merged
merged 2 commits into from
Sep 19, 2023
Merged

config: enable crash_loop_limit by default #13431

merged 2 commits into from
Sep 19, 2023

Commits on Sep 15, 2023

  1. config: Do not enforce crash_loop_limit in developer_mode 

    This disables it also for dev-container mode in rpk

The idea is that crash_loop_limit tracking has value only when running
at scale and disabling it prevents inadverdent lockups (and hence better
UX) when running in container mode / CI etc.
    @bharathv
    bharathv committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    43749ea View commit details
    Browse the repository at this point in the history

  2. config: enable crash_loop_limit by default 

    Defaults to 5. If a broker shuts down uncleanly 5 times back to back,
it is considered to be in a crash loop.
    @bharathv
    bharathv committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    12b5afa View commit details
    Browse the repository at this point in the history