[v23.1.x] archival: avoid replicating empty read replica batch #14634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty batches aren't well-handled and can result in corrupted segments. This commit adjusts read replicas to avoid this when there is no difference between the remote manifest and in-memory manifest.
|
should we add a strategically placed flag in redpanda to prevent empty batches? it kinda seems based on this coverletter that even though we don't have empty batches in upstream, there still lurks bugs if we empty batches did show up int he future? |
Lazin
approved these changes
Nov 7, 2023
|
/backport v22.3.x |
|
The pull request's base branch is not the default one. Cancelling backport... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This doesn't exist in v23.2.x and above.
Empty batches aren't well-handled and can result in corrupted segments. This commit adjusts read replicas to avoid this when there is no difference between the remote manifest and in-memory manifest.
Backports Required
Release Notes
Bug Fixes