[v23.2.x] segment_meta_cstore: handle gaps and overlaps #14954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two issues with the `insert_entries` method 1. It could not handle insertions in a previously created gap. This is because it used the `find` method, which requires an exact match with an existing segment, in order to determine if the insert should go somewhere in the middle of the cstore or at the end. 2. It did the merging in terms of the committed offset. This could result in the merge having out of order base offsets, which, in turn, causes the encoder to assert out. Fixes are as follows: 1. Instead of using `find`, use lower_bound with the incoming base_offset, to handle gaps in the pre-existing store. 2. Use base offset comparison when doing the merge, to allow for overlaps. (cherry picked from commit 0c2bee3)
this is mostly to make the code easier to navigate with the ide (cherry picked from commit 25da8e9)
like insert_entries, update the logic to erase replaced segments to allow for overlaps. before, the code would search of the first segment completely after the range covered by the new segment. now it searches for the first segment that ends after the range covered by the new segment. (cherry picked from commit 98899a9)
dotnwat
approved these changes
Nov 14, 2023
andrwng
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #14856