rpk debug bundle: save additional admin API requests. #15136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes existing methods in our adminapi package to the debug bundle.
r-vasquez
commented
Nov 27, 2023
| @@ -204,40 +200,3 @@ func runToggle(ctx context.Context, cl *adminapi.AdminAPI, all bool, topicArg, p | |||
| } | |||
| return g.Wait() | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This was moved to the out package. The toggle_test.go file was deleted and moved to in_test.go (inside out package)
twmb
previously approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Although it's good the new api's are added to the adminapi package, it's probably worth it to have some blind GetLeader(context, path) and GetAny(...) type of request, so that it's less work to just request arbitrary endpoints and capture the arbitrary results.
Anyway, might be good for the future but this is good now too
This introduce the ability to pass a partition flag to `rpk debug bundle`, if passed, rpk will save extra requests to the admin API.
r-vasquez
force-pushed
the
add-admin-bundle
branch
from
1a96eda
to
7fac14c
Compare
twmb
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces more admin API requests to the debug bundle as well as a way to add extra request for specific topic/partitions.
--partition/-pflag and the new extra request if this flag is provided.Fixes #14483
Backports Required
Release Notes
Features
--partitionflag to request additional debugging information to the admin API for the provided partitions.Improvements