Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rptest: ignore test_cloud_cache_thrash #15199

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

nvartolomei
Copy link
Contributor

@nvartolomei nvartolomei commented Nov 29, 2023

Ignore test_cloud_cache_thrash to avoid wasting resources on a test which does nothing. See code comment for rationale.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

  • none

@vbotbuildovich
Copy link
Collaborator

Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from discussion with @nvartolomei, if this PR will bring in changes to knowingly fail the test for the purpose of diagnosis, would be best to add an @ok_to_fail. or may need to update the test or delete the test if a similar test is already run in a non-cloud env.

@nvartolomei nvartolomei requested review from andrewhsu and removed request for andrewhsu April 18, 2024 13:45
@nvartolomei nvartolomei marked this pull request as draft April 18, 2024 13:46
@nvartolomei nvartolomei marked this pull request as ready for review April 18, 2024 18:19
@nvartolomei nvartolomei changed the title rptest: assert that test_cloud_cache_thrash writes to cache rptest: disable test_cloud_cache_thrash Apr 18, 2024
@nvartolomei nvartolomei changed the title rptest: disable test_cloud_cache_thrash rptest: ignore test_cloud_cache_thrash Apr 18, 2024
@nvartolomei
Copy link
Contributor Author

From an actual run: AssertionError: Expected at least 800 cache misses, got 0

Copy link
Contributor

@savex savex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvartolomei nvartolomei merged commit 4c8db94 into redpanda-data:dev Apr 22, 2024
19 checks passed
@nvartolomei nvartolomei deleted the nv/htt-assert-cache-misses branch April 22, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants