[v23.2.x] remote_partition_fuzz_test: measure shutdown time directly #15246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gging this logging demostrate how the active part of the test takes only only ~10 lines of logging. with this it should be possible to better reconstruct a failed test run
instead of relying on ss::with_timeout log shows that close_fut can take more than 10ms to trigger the shutdown, in underprovisioned systems this can trigger ss::with_timeout because the runtime can start the timer way before triggering shutdown_connections. measuring the actual shutdown time in the same fiber as shutdown_connection should remove this problem
remove try-catch construct, meant to acquire and log an expected ss::timed_out_error exception. now that ss::with_timeout is not used anymore, it can be removed
piyushredpanda
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #15142
Backport of PR #15200
Fixes #15234