audit: Replaced __audit with __audit_log

[michael-redpanda]

__audit was the original name of the audit log topic that was added
long before the audit feature was designed and developed. By
replacing all __audit with __audit_log, the audit log will no longer
be part of billing.

Fixes: #15324

Signed-off-by: Michael Boquard michael@redpanda.com

Backports Required

• none - not a bug fix
• none - this is a backport
• none - issue does not exist in previous branches
• none - papercut/not impactful enough to backport
• v23.2.x
• v23.1.x
• v22.3.x

Release Notes

• none

[vbotbuildovich]

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/42305#018c3cda-0565-498e-acc2-aceba3482484

[michael-redpanda]

Force push 50b3be6:

Removed __audit_log from noproduce cluster config option

[michael-redpanda]

unit test failure: #13275

[dotnwat]

is exclusion of the audit topic implemented somewhere else? i looked around but didn't see it.

[michael-redpanda]

yes this is handled in the produce handler

redpanda/src/v/kafka/server/handlers/produce.cc

Lines 522 to 536 in 2915bc8

	const bool audit_produce_restricted
	= !octx.rctx.authorized_auditor()
	&& topic.name == model::kafka_audit_logging_topic();
	// Need to make an exception here in case the audit log topic is in the
	// noproduce topics list
	const bool is_audit_produce
	= octx.rctx.authorized_auditor()
	&& topic.name == model::kafka_audit_logging_topic();
	if (
	(is_noproduce_topic || audit_produce_restricted)
	&& !is_audit_produce) {
	push_error_response(error_code::topic_authorization_failed);
	continue;
	}