[v23.2.x] Made leader_id and term changes atomic #15333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an error in Redpanda Raft protocol implementation leading to reporting inconsistent leadership information. Previously it may happened that the protocol `_term` was updated but `_leader_id` was not. This might lead to situation in which a caller querying `term()` and `leader_id()` method would receive new `term` value but the old `leader_id`. The problem is limited to metadata and does not influence protocol correctness as all the protocol checks are correct. The issue might have been underlying some tests failures as the incorrect leadership information might have propagated through health report leading to leadership metadata staleness. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 1819bad)
mmaslankaprv
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #15294
Fixes: #15331,