[v23.2.x] rpk: manually update golangci-lint version #15364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use latest in dev, but v22.3 was using an old version that was causing errors in CI
r-vasquez
requested review from
twmb,
gene-redpanda and
a team
as code owners
twmb
approved these changes
Dec 7, 2023
gene-redpanda
approved these changes
Dec 7, 2023
andrewhsu
changed the title
andrewhsu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
latestin dev, but v22.3 was using an oldversion that was causing errors in CI
Why?
Our GH actions:
stableversion.From the GH Actions Doc, Go's
stableversion comes from the go-version repository manifest and this was updated yesterday to 1.21.5, andgolangci-lint@1.52is incompatible with this new version.Backports Required
Release Notes