[v23.2.x] rpk produce: Adjust timeout and maxBytes options #15380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. ProduceRequestTimeout: we are now using the duration set by `--delivery-timeout` to also adjust the ProduceRequestTimeout. We are using the same flag to avoid adding another knob that may lead to confusion. 2. BrokerMaxWriteBytes: we were only adjusting the ProducerBatchMaxBytes with the `--max-message-bytes`, that means we were only maxing out batch bytes but not the broker max bytes and we would likely hit the broker byte batch limit if not increased.is limit if we were producing a record big enough. (cherry picked from commit 49dcd7a)
r-vasquez
approved these changes
Dec 8, 2023
twmb
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #15371
Fixes: #15379,