Backport of #12716 avoid returning stale describeACL responses #15437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When handling this request the responding broker must be the current leader and will return the last_committed offset within its respective controller log. - This offset represents the highest command that has been completely processed by the controller log.
- This routine will, contact the leader for the last_committed offset within the controller log, then wait for its local stm to have caught up until at least that point.
- Before handling describe ACLs requests, ensure that if this node is a follower, its processing of controller commands has caught up with the leaders at the point in time the request was recieved.
- This raises the election timeout to 10s while network partitioning a leader then making a describeACLs request. - In this scenario any node that is queried should be reporting that stale results may be returned. Previous followers will be reporting this because they cannot reach the leader, and the stale leader will be reporting this because it cannot inject a barrier since it had been network partitioned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12716
Backports Required
Release Notes
Improvements