[v23.2.x] storage/disk_log_impl: defensive reverse iteration of _segs #15602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if _segs is empty (not in the precondition) size() -1 would underflow and we would access garbage if _segs has size 1, we would underflow afther the loop check (i-->0) and access garbage if _segs is bigger than 1, we would exclude from the count the active segment (cherry picked from commit ba0384e)
see issues/15417 (cherry picked from commit fcf433c)
vbotbuildovich
requested review from
dotnwat,
abhijat,
nvartolomei and
andrwng
|
/dt |
andrwng
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #15440
Fixes: #15601,