Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.2.x] Add truncating_logger and formatter specializations for metadata_* API types #15621

Merged
merged 7 commits into from
Dec 15, 2023
Merged

[v23.2.x] Add truncating_logger and formatter specializations for metadata_* API types #15621

merged 7 commits into from
Dec 15, 2023

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #15327

@oleiman @vbotbuildovich
utils: Add truncating_logger
da0f3d3 
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit ef0b79a)
@oleiman @vbotbuildovich
kafka/protocol/logger: Adds kwire truncating_logger
294956f 
Max line size: 1MiB

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit fc2e71d)
@oleiman @vbotbuildovich
kafka: Replace klog with kwire for kafka req/resp logging
548f441 
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 7e88ca9)
@oleiman @vbotbuildovich
kafka/client/logger: Adds kcwire truncating_logger
66ec272 
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 06a4880)
@oleiman @vbotbuildovich
kafka/client: Replace kclog with kcwire for kafka req/resp logging
d7491e0 
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 3e6732e)
@oleiman @vbotbuildovich
kafka/metadata_response: Add custom formatter specialization
445a0ac 
And remove `operator<<`

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 61c1a65)
@oleiman @vbotbuildovich
kafka/generator.py: Generate fmt::formatter specializations
9e6bbaf 
For the following structs:
- `metadata_response_data`
- `metadata_response_topic`
- `metadata_response_partition`
- `metadata_response_broker`

This provides us with greater control of response data formatting for
structs which might be very large.

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 3be3336)
@vbotbuildovich vbotbuildovich added this to the v23.2.x-next milestone Dec 15, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Dec 15, 2023
@oleiman oleiman marked this pull request as ready for review December 15, 2023 00:08
@oleiman
Copy link
Member

oleiman commented Dec 15, 2023

/ci-repeat 1

@oleiman oleiman self-assigned this Dec 15, 2023
oleiman
oleiman approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-approving clean backport

@oleiman oleiman merged commit 1405b01 into redpanda-data:v23.2.x Dec 15, 2023
24 checks passed
@piyushredpanda piyushredpanda modified the milestones: v23.2.x-next, v23.2.20 Dec 19, 2023
This was referenced Dec 21, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleiman oleiman oleiman approved these changes

@michael-redpanda michael-redpanda Awaiting requested review from michael-redpanda

Assignees

@oleiman oleiman

Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.2.20
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbotbuildovich @oleiman @piyushredpanda