Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rptest: add test_add_and_decommission() #15701

Merged
merged 3 commits into from
Dec 28, 2023
Merged

rptest: add test_add_and_decommission() #15701

merged 3 commits into from
Dec 28, 2023

Conversation

andrewhsu
Copy link
Member

@andrewhsu andrewhsu commented Dec 16, 2023 •
edited

Fixes https://github.com/redpanda-data/cloudv2/issues/10807

Blocked by PR: https://github.com/redpanda-data/vtools/pull/2407

Example command to run new test:

ducktape \
  --debug \
  --globals=/home/ubuntu/redpanda/tests/globals.json \
  --cluster=ducktape.cluster.json.JsonCluster \
  --cluster-file=/home/ubuntu/redpanda/tests/cluster.json \
  --test-runner-timeout=3600000 \
  tests/rptest/redpanda_cloud_tests/high_throughput_test.py::HighThroughputTest.test_add_and_decommission

output from test run:

test_id:    rptest.redpanda_cloud_tests.high_throughput_test.HighThroughputTest.test_add_and_decommission
status:     PASS
run time:   11 minutes 35.892 seconds
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
============================================================================================================================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.8.18
session_id:       2023-12-21--006
run time:         11 minutes 35.913 seconds
tests run:        1
passed:           1
flaky:            0
failed:           0
ignored:          0
opassed:          0
ofailed:          0
==========================================================================================================================================================================================

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@andrewhsu andrewhsu force-pushed the add-and-decomm branch 3 times, most recently from 4b9f457 to 80613a4 Compare December 19, 2023 14:50
@andrewhsu
Copy link
Member Author

/dt

@andrewhsu
Copy link
Member Author

test run output coming soon (need to rebuild dev env), but in the meantime this PR is ready for review

@andrewhsu andrewhsu marked this pull request as ready for review December 19, 2023 14:53
savex
savex previously approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@savex savex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on green build.

side note: I would move in the future the tests that related to day-2 operations to separate module to tidy up. Something like redpanda_cloud_tests/htt_operations_tests.py and rename this file to htt_limits_test.py. That would be more meaningful in scope what tests are actually doing.

@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/43054#018c82d7-0744-40ec-9576-7f4bfa152f9c:

"rptest.tests.cloud_storage_usage_test.CloudStorageUsageTest.test_cloud_storage_usage_reporting"

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Dec 20, 2023 •
edited

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43077#018c844d-2794-47c8-8603-48d611186154

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43208#018c8c0d-8e0b-4be8-82c9-6e9de789feaa

@andrewhsu
Copy link
Member Author

needs adjustment on the systemctl services. putting this back into draft mode for now while i'll get an update for that.

@andrewhsu andrewhsu marked this pull request as draft December 20, 2023 15:27
@andrewhsu andrewhsu force-pushed the add-and-decomm branch 4 times, most recently from ba310e2 to 2eaf6bf Compare December 21, 2023 09:21
@andrewhsu
Copy link
Member Author

fixed the systemctl service. the agent services have to be running when making the call to admin-api to scale nodes.

i've also added a successful test output to the PR description. ready for review.

@andrewhsu andrewhsu marked this pull request as ready for review December 21, 2023 09:50
@andrewhsu andrewhsu requested a review from savex December 21, 2023 13:59
savex
savex reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@savex savex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. One doubled code though

tests/rptest/redpanda_cloud_tests/high_throughput_test.py
self._delete_cluster_pvc(cluster_name, orig_replicas)
self._patch_deployment_args('--allow-downscaling=true',
'--allow-downscaling=false')
self._enable_agent_services()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a clean-good-looking test code!

tests/rptest/redpanda_cloud_tests/high_throughput_test.py
def _patch_cluster_replicas(self, cluster_name, replicas):
def cluster_ready_replicas(cluster_name):
# kubectl get cluster rp-clkd0n22nfn1jf7vd9t0 -n=redpanda -o=jsonpath='{.status.readyReplicas}'
return int(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the difference here with line 1119?

@piyushredpanda piyushredpanda merged commit 5f33712 into redpanda-data:dev Dec 28, 2023
18 checks passed
@andrewhsu andrewhsu deleted the add-and-decomm branch January 2, 2024 14:36
@andrewhsu andrewhsu mentioned this pull request Feb 6, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savex savex savex left review comments

@piyushredpanda piyushredpanda piyushredpanda approved these changes

@travisdowns travisdowns Awaiting requested review from travisdowns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewhsu @vbotbuildovich @savex @piyushredpanda