c/log_eviction_stm: do not take the snapshot if start offset progressed #15731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphcareful
previously approved these changes
Dec 18, 2023
ztlpn
reviewed
Dec 18, 2023
Taking a snapshot is an asynchronous process which may interleave with Raft protocol receiving an install snapshot request. This way Raft start offset may already progress beyond what was requested by `log_eviction_stm`. This is correct but `log_eviction_stm` should skip writing a snapshot as it would fail either way. Fixes: redpanda-data#15705 Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
fix-15705
branch
from
bba94b9
to
53ca208
Compare
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43033#018c813b-6875-4f19-9df5-7f2efdbb6bce |
ztlpn
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a snapshot is an asynchronous process which may interleave with Raft protocol receiving an install snapshot request. This way Raft start offset may already progress beyond what was requested by
log_eviction_stm. This is correct butlog_eviction_stmshould skip writing a snapshot as it would fail either way.Fixes: #15705
Backports Required
Release Notes