Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.2.x] cloud_storage: Make wait for hydration abortable #15732

Merged

Conversation

andrwng
Copy link
Contributor

@andrwng andrwng commented Dec 18, 2023

Backport of #15351

Conflicts:

  • surrounding test in ducktape test was different, resulting in a conflict

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

A 10 minute hydration timeout is added. If the hydration request is not
completed within this time period, the consumer is notified with a
timeout error. The download which happens in the remote segment via a
condition variable may still progress, but the connection to the
consumer can be closed.

(cherry picked from commit 80958b1)
A consumer may disconnect while waiting for hydration. The fiber waiting
for hydration in redpanda should be able to react to this and stop
waiting, thus enabling the kafka connection to close. Additionally, the
hydration may get blocked somewhere for long period of time, in which
case it is useful to be able to abort the wait for hydration.

This change allows the fiber waiting for the hydration to complete to
abort if the consumer disconnects or there is a timeout. In either case
the download continues uninterrupted, only the consumer is allowed to
close the fetch path early.

(cherry picked from commit dba77b0)
CONFLICT: surrounding test was different

(cherry picked from commit f8927fe)
@andrwng andrwng requested review from abhijat, Lazin, dotnwat, andijcr and nvartolomei and removed request for abhijat December 18, 2023 16:52
@piyushredpanda
Copy link
Contributor

/dt

@andrwng andrwng merged commit 8ee81c6 into redpanda-data:v23.2.x Dec 19, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants