[v23.2.x] cloud_storage: Make wait for hydration abortable #15732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A 10 minute hydration timeout is added. If the hydration request is not completed within this time period, the consumer is notified with a timeout error. The download which happens in the remote segment via a condition variable may still progress, but the connection to the consumer can be closed. (cherry picked from commit 80958b1)
A consumer may disconnect while waiting for hydration. The fiber waiting for hydration in redpanda should be able to react to this and stop waiting, thus enabling the kafka connection to close. Additionally, the hydration may get blocked somewhere for long period of time, in which case it is useful to be able to abort the wait for hydration. This change allows the fiber waiting for the hydration to complete to abort if the consumer disconnects or there is a timeout. In either case the download continues uninterrupted, only the consumer is allowed to close the fetch path early. (cherry picked from commit dba77b0)
CONFLICT: surrounding test was different (cherry picked from commit f8927fe)
andrwng
requested review from
abhijat,
Lazin,
dotnwat,
andijcr and
nvartolomei
and removed request for
abhijat
andijcr
approved these changes
Dec 18, 2023
|
/dt |
This was referenced Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #15351
Conflicts:
Backports Required
Release Notes