c/members_member: don't ignore update_broker_client future #15738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
A new clang tidy check I'm developing caught that we're not awaiting for the future `f` to finish. I've converted it into a coroutine and co_awaited this future, which I assume is the intended semantics. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
rockwotj
force-pushed
the
unused-future
branch
from
08c5062
to
da3d491
Compare
rockwotj
commented
Dec 18, 2023
| } | ||
|
|
||
| auto f = update_broker_client( |
There was a problem hiding this comment.
Previously, f was never awaited upon. I'm not sure if that was intended to be backgrounded, or if we want to wait for it, I'm assuming we should wait for it, (hence coroutinizing this method) but if the intention is to background it, then I'll happily replace this with ssx::backgrounded
mmaslankaprv
approved these changes
Dec 19, 2023
|
/backport v23.3.x |
|
/backport v23.2.x |
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new clang tidy check I'm developing caught that we're not awaiting for
the future
fto finish. I've converted it into a coroutine andco_awaited this future, which I assume is the intended semantics.
Backports Required
Release Notes