cluster_recovery: direct requests to controller leader #15740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that controller leaders are the ones that drive restore, the status endpoint should also be the one to report cluster recovery. Otherwise, the cluster restore may indicate completion without actually having finished the restore.
Cluster restore is driven by the controller leader. The `rpk` command should follow suit.
andrwng
requested review from
twmb,
r-vasquez and
gene-redpanda
as code owners
r-vasquez
approved these changes
Dec 18, 2023
|
CI failure: #15679 |
|
/backport v23.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For robustness of the endpoint, it's expected that the restore and subsequent status calls are directed to the leader. Otherwise, a random stale node could indicate that no recovery is in progress, while it actually is.
Backports Required
Release Notes