cloud_storage_clients: use appropriate beast error for end of stream #15743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functionality changes except the log messages. While testing Redpanda against real S3 endpoint I got concerned by log messages looking like this: `Server disconnected: 'unexpected eof in body [beast.http:26]', retrying HTTP request`. As a result, spent 3 hours debugging why S3 would close connection mid-message. The problem was that we were using a bit of an inappropriate message to indicate cleanly closed connection. Use a more appropriate error code to avoid confusion in the future.
|
/dt |
Beast handles incomplete headers and errors out with partial message error code. Report end of stream error only when it is actually the case, i.e. no bytes received at all.
|
/dt |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/42998#018c7f57-cfe2-4f96-aa85-b454146706a7 |
Lazin
reviewed
Dec 19, 2023
Lazin
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functionality changes except the log messages. While testing Redpanda against real S3 endpoint I got concerned by log messages looking like this:
Server disconnected: 'unexpected eof in body [beast.http:26]', retrying HTTP request.As a result, spent 3 hours debugging why S3 would close connection mid-message. The problem was that we were using a bit of an inappropriate message to indicate cleanly closed connection. Use a more appropriate error code to avoid confusion in the future.
Backports Required
Release Notes