k/h/metadata: use fragmented vec for topic metadata #15751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
force-pushed
the
metadata-alloc
branch
2 times, most recently
from
859e8ce
to
f474465
Compare
rockwotj
force-pushed
the
metadata-alloc
branch
from
f474465
to
6b19d55
Compare
oleiman
previously approved these changes
Dec 19, 2023
rockwotj
force-pushed
the
metadata-alloc
branch
from
6b19d55
to
afd4178
Compare
|
Force push: remove out of date comment |
oleiman
previously approved these changes
Dec 19, 2023
rockwotj
force-pushed
the
metadata-alloc
branch
from
afd4178
to
1b46d08
Compare
|
Force push: use |
oleiman
previously approved these changes
Dec 19, 2023
For workloads with a large amount of topics, this topics vector can grow to be an oversized allocation. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
rockwotj
force-pushed
the
metadata-alloc
branch
from
1b46d08
to
c535652
Compare
travisdowns
reviewed
Dec 19, 2023
| @@ -108,8 +108,8 @@ class delete_topics_request_fixture : public redpanda_thread_fixture { | |||
| void validate_topic_is_deleteted(const model::topic& tp) { | |||
| kafka::metadata_response resp = get_topic_metadata(tp); | |||
| auto it = std::find_if( | |||
| std::cbegin(resp.data.topics), | |||
| std::cend(resp.data.topics), | |||
| resp.data.topics.begin(), | |||
There was a problem hiding this comment.
This is because fragmented_vector is missing const-qualified versions of begin & end?
There was a problem hiding this comment.
I believe you cannot compare const iterator to non const in frag vector, and you can in vector, so I just switch this all to use the non constant version (in the assertion below)
travisdowns
approved these changes
Dec 19, 2023
graphcareful
approved these changes
Dec 19, 2023
BenPope
approved these changes
Dec 19, 2023
|
/backport v23.3.x |
|
/backport v23.2.x |
|
Failed to create a backport PR to v23.2.x branch. I tried: |
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For workloads with a large amount of topics, this topics vector can grow
to be an oversized allocation.
Backports Required
Release Notes
Improvements