follow-up: config/config_store_test: ignored_keys test #15765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43042#018c81e2-cfcc-4b36-a2eb-aa1ddefcb827 |
andrwng
reviewed
Dec 19, 2023
Comment on lines
549
to
551
| // actual test: check that noop_cfg can ignore properties for test_config | ||
| auto noop_cfg = noop_config{}; | ||
| BOOST_REQUIRE_NO_THROW(noop_cfg.read_yaml( |
There was a problem hiding this comment.
Would it also make sense to read_yaml() into a config that has aliased_bool_legay=True and check that it is ignored?
There was a problem hiding this comment.
ah but that's not how it works: the parameter is called ignored_missing: if the yaml key is not found in the properties of the caller, then it will throw std::illegal_argument unless it's in ignore_missing.
I'll add an extension to show this
There was a problem hiding this comment.
Ah, much clearer now! Thank you!
andijcr
force-pushed
the
followup/config_store_property_name_and_aliases
branch
from
2cb3359
to
6e051f0
Compare
|
force push: rewrote the test to show how ignore_missing parameter work and should be used |
this test is mainly concerned with showing how to use config_store::read_yaml and how to ignore unknown keys that needs to be intepreted by a separate config_store related to issues/15759
andijcr
force-pushed
the
followup/config_store_property_name_and_aliases
branch
from
6e051f0
to
b33ece9
Compare
andrwng
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is mainly concerned with showing how to use config_store::read_yaml and how to ignore unknown keys that need to be interpreted by a separate config_store
related to #15759
followup for #15605
Backports Required
Release Notes