c/rm_stm: cleanup tx_locks #15796
Merged
c/rm_stm: cleanup tx_locks #15796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
force-pushed
the
stop-the-leak
branch
from
5aa6a33
to
6fe1ea9
Compare
We never cleanup tx_locks, clear_old_tx_pids seems like the right place to be doing this. Two things: 1. We should be ensuring the tx_lock isn't held when expiring, this mirrors the logic in `is_producer_expired`. 2. We actually need to erase the pid from the tx_lock. Right now it grows unboundedly. It seems possible that a producer of the same ID but a higher epoch could be holding/using the lock, so in that case we don't need to do anything, otherwise we can GC the lock when cleaning up the PID. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
rockwotj
force-pushed
the
stop-the-leak
branch
from
6fe1ea9
to
cf3d49c
Compare
mmaslankaprv
approved these changes
Dec 20, 2023
|
/backport v23.1.x |
|
The pull request's base branch is not the default one. Cancelling backport... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never cleanup tx_locks, clear_old_tx_pids seems like the right place
to be doing this. Two things:
mirrors the logic in
is_producer_expired.grows unboundedly.
So when we collect our pids to delete we break the mutex so that if that
pid is ever used again before deleting it from the map we will not allow
progress. I am not sure if we need error handling someplace special for
this potentially broken semaphore.
Backports Required
Release Notes
Bug Fixes