c/rm_stm: cleanup tx_locks #15797
Merged
c/rm_stm: cleanup tx_locks #15797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not really fully convinced that we even need the tx_lock map, can't we use the |
|
Actually nevermind do we need that to guard against different epochs still? |
rockwotj
force-pushed
the
cleanup-the-tx-locks
branch
from
b26e947
to
05b59cc
Compare
Currently tx_locks are never cleaned up and the _tx_locks map grows unboundedly. Fix this by removing the lock when we cleanup the producer state. I'm not sure if we can remove the lock (optimistically?) when transactions are aborted or committed, as we erase some in memory state at that point. I'm being more catious and not doing that in this PR, but it seems like if nobody is holding the lock at the time when we abort/commit a transaction, we can clean the lock up, as it's only there to prevent concurrent tx related requests for a single pid. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
rockwotj
force-pushed
the
cleanup-the-tx-locks
branch
from
05b59cc
to
2c42ea1
Compare
mmaslankaprv
approved these changes
Dec 20, 2023
|
/backport v23.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently tx_locks are never cleaned up and the _tx_locks map grows
unboundedly. Fix this by removing the lock when we cleanup the producer
state. I'm not sure if we can remove the lock (optimistically?) when
transactions are aborted or committed, as we erase some in memory state
at that point. I'm being more catious and not doing that in this PR, but
it seems like if nobody is holding the lock at the time when we
abort/commit a transaction, we can clean the lock up, as it's only there
to prevent concurrent tx related requests for a single pid.
NOTE: I already have a backport up in 23.2.x
Backports Required
Release Notes
Bug Fixes