Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archival: disable scrubber by default #15813

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

nvartolomei
Copy link
Contributor

Keep it enabled for all the tests. Need some extra time to understand the cost implications for high usage clusters.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@nvartolomei
Copy link
Contributor Author

/dt

@dotnwat
Copy link
Member

dotnwat commented Dec 21, 2023

@nvartolomei looks good to me. all of the failures are curiously timeouts in storage tests. my hunch is that the spot where you enabled scrubbing in tests wasn't sufficient to enable it for every test--maybe there are some other spots where it needs to be enabled?

@dotnwat dotnwat modified the milestone: v23.3.1-rc5 Dec 21, 2023
@redpanda-data redpanda-data deleted a comment from vbotbuildovich Dec 21, 2023
@redpanda-data redpanda-data deleted a comment from vbotbuildovich Dec 21, 2023
Keep it enabled for all the tests. Need some extra time to understand
the cost implications for high usage clusters.
@nvartolomei
Copy link
Contributor Author

/dt

@vbotbuildovich
Copy link
Collaborator

@nvartolomei nvartolomei marked this pull request as ready for review December 21, 2023 16:31
@dotnwat dotnwat merged commit c96cf24 into redpanda-data:dev Dec 21, 2023
21 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants