cluster/config_manager: ensure cleanup of old aliases #15815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: if storing the proper name, the cleanup would be skipped
andijcr
force-pushed
the
fix/cleanup_config_translation
branch
from
afea16c
to
354cfd8
Compare
|
/dt |
rockwotj
approved these changes
Dec 20, 2023
Comment on lines
1417
to
1418
| # NOTE due to https://github.com/redpanda-data/redpanda/issues/13432 , | ||
| # test_values can't be -1 (a valid value nonetheless to signal infinite value) |
There was a problem hiding this comment.
Is this the right spot for this comment?
There was a problem hiding this comment.
Right it makes more sense before log_retention_ms. Will do in a followup
|
/backport v23.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config aliases:
Part of the fix for #15263 requires ensuring that a cluster property is saved only once in the config_manager::_raw_values map.
When storing a property, the name is converted to the main property name and any aliases are removed from the map, in case the node inherits the snapshot from an old version.
the fix make sure that the cleanup part is always performed, before this it would be skipped the incoming key was already the main name
Backports Required
Release Notes