Skip assertion in audit log tests if results beat the baseline #15820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the most recent run of the audit log scale tests:
The test ended up failing because the results beat the baseline by greater then the hardcoded 10% threshold:
The difference between p90 results is 17% however the enabled run was better !
This patch changes the logic to only perform the assertion in the case the run didn't beat the baseline run. Also removes the
ok_to_fail
tagBackports Required
Release Notes