Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip assertion in audit log tests if results beat the baseline #15820

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

graphcareful
Copy link
Contributor

@graphcareful graphcareful commented Dec 20, 2023

From the most recent run of the audit log scale tests:

Traceback (most recent call last):
  File "/home/ubuntu/redpanda/tests/rptest/services/cluster.py", line 82, in wrapped
    r = f(self, *args, **kwargs)
  File "/home/ubuntu/redpanda/tests/rptest/scale_tests/audit_log_test.py", line 413, in test_audit_log
    assert pct_difference(audit_disabled_results.p90,
AssertionError

The test ended up failing because the results beat the baseline by greater then the hardcoded 10% threshold:

[INFO  - 2023-12-20 13:02:43,395 - audit_log_test - test_audit_log - lineno:402]: audit_disabled_results: {'time_elapsed': 163.91215109825134, 'total_produced': 837362, 'total_consumed': 837330, 'p50': 15477.83203125, 'p90': 134794.0625, 'p99': 839466.16796875}
[INFO  - 2023-12-20 13:02:43,395 - audit_log_test - test_audit_log - lineno:404]: audit_enabled_results: {'time_elapsed': 178.89132976531982, 'total_produced': 913621, 'total_consumed': 913596, 'p50': 16713.26171875, 'p90': 112903.02734375, 'p99': 730726.29296875}

The difference between p90 results is 17% however the enabled run was better !

This patch changes the logic to only perform the assertion in the case the run didn't beat the baseline run. Also removes the ok_to_fail tag

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vbotbuildovich
Copy link
Collaborator

@graphcareful graphcareful merged commit f4f85d3 into redpanda-data:dev Jan 3, 2024
17 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants