rpk: Print create topics error message if available #15837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Boquard <michael@redpanda.com>
michael-redpanda
requested review from
twmb,
r-vasquez and
gene-redpanda
as code owners
twmb
approved these changes
Dec 21, 2023
|
/backport v23.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of
minimum_topic_replications, topic creation usingrf=-1(therefor relying ondefault_topic_replications) may now fail because the default is less than the minimum. Originally, rpk would assume that the failure was becausedefault_topic_replicationswas not odd. This change will now display the error message, ifone was provided, in this situation.
Backports Required
Release Notes
Improvements