Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka: Don't set rack ID if empty #15846

Merged

Conversation

michael-redpanda
Copy link
Contributor

Take into consideration that if the fetch request's rack ID is an empty string, act as if no rack ID was provided.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

Bug Fixes

  • Redpanda will now correctly handle an empty rack ID provided in a fetch request

Take into consideration that if the fetch request's rack ID is
an empty string, act as if no rack ID was provided.

Signed-off-by: Michael Boquard <michael@redpanda.com>
Copy link
Contributor

@rockwotj rockwotj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@vbotbuildovich
Copy link
Collaborator

@michael-redpanda michael-redpanda merged commit e2ec12a into redpanda-data:dev Dec 21, 2023
20 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants