[v23.2.x] Fix/v23.2.x/cfg unchecked test #15874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfg.get() can throw std::out_of_range if the name is not known by redpanda. this can be the case for unknown properties that nonetheless gets written to the controller log, and later loaded again during startup
andijcr
changed the title
abhijat
approved these changes
Jan 5, 2024
abhijat
reviewed
Jan 5, 2024
| if (cfg.contains(key)) { | ||
| auto& property = cfg.get(key); |
There was a problem hiding this comment.
cfg can probably now go into if with init-statement.
There was a problem hiding this comment.
can't, it would still throw std::out_of_range if no key is found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfg.get() can throw std::out_of_range if the name is not known by redpanda.
this can be the case for unknown properties that nonetheless gets written to the controller log, and later loaded again during startup
Backport of PR #15840