Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka: Disable FF if rack awareness is disabled #15883

Conversation

michael-redpanda
Copy link
Contributor

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

Bug Fixes

  • Have fetch handler ensure rack awareness is enabled before performing follower fetching

Signed-off-by: Michael Boquard <michael@redpanda.com>
@emaxerrno
Copy link
Contributor

Makes sense, because FF is enabled by default w/ client settings. Wonder if the degenerative case is every computer in a single rack has rack-labels as a way to have catch up workloads .... so instead of "rack-awareness:true" it is a function of rack-awareness-label.size() == 0 ... does that make sense? like should we drop the rack-awareness true and always make it true if rack-awareness-labels are existing.

in other words should the flag be only for disabling rather than for enabling

@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/43316#018c92a5-ef84-4540-bf53-8b883e38e6d0:

"rptest.tests.cloud_retention_test.CloudRetentionTest.test_cloud_retention.max_consume_rate_mb=20.cloud_storage_type=CloudStorageType.ABS"

@michael-redpanda
Copy link
Contributor Author

#15913

@piyushredpanda piyushredpanda merged commit 2ccf3a7 into redpanda-data:dev Jan 2, 2024
18 of 20 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants