Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gha: improve backport reviewers #15890

Merged
merged 1 commit into from
Jan 2, 2024
Merged

gha: improve backport reviewers #15890

merged 1 commit into from
Jan 2, 2024

Conversation

rockwotj
Copy link
Contributor

@rockwotj rockwotj commented Dec 22, 2023 •
edited

In the case of a clean backport, the original PR author is the reviewer,
otherwise when creating an issue, we don't list reviewers, as we assume
the reviewer will assign them appropriately.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@rockwotj rockwotj requested a review from a team as a code owner December 22, 2023 20:11
@rockwotj rockwotj requested review from gousteris and removed request for a team December 22, 2023 20:11
@rockwotj rockwotj requested a review from a team December 22, 2023 20:14
dotnwat
dotnwat previously approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to me

@rockwotj
gha: improve backport reviewers
bb1b362 
In the case of a clean backport, the original PR author is the reviewer,
otherwise when creating an issue, we don't list reviewers, as we assume
the reviewer will assign them appropriately.

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj
Copy link
Contributor Author

Force push: fix when the backport script is called on an issue (I didn't know it did that!)

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Dec 22, 2023 •
edited

new failures in https://buildkite.com/redpanda/redpanda/builds/43331#018c937c-f474-40b9-9e40-9920217f406a:

"rptest.tests.cloud_retention_test.CloudRetentionTest.test_cloud_retention.max_consume_rate_mb=20.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.cloud_storage_timing_stress_test.CloudStorageTimingStressTest.test_cloud_storage_with_partition_moves.cleanup_policy=delete"

new failures in https://buildkite.com/redpanda/redpanda/builds/43331#018c9382-6a6f-40ce-a82c-af33c9a8e182:

"rptest.tests.nodes_decommissioning_test.NodesDecommissioningTest.test_decommissioning_working_node.delete_topic=True.tick_interval=3600000"

new failures in https://buildkite.com/redpanda/redpanda/builds/43336#018c94aa-34b9-4ad8-b24e-07a3402ce046:

"rptest.tests.cloud_retention_test.CloudRetentionTest.test_cloud_retention.max_consume_rate_mb=None.cloud_storage_type=CloudStorageType.S3"

new failures in https://buildkite.com/redpanda/redpanda/builds/43336#018c9f48-7ada-46be-8615-976913ecc615:

"rptest.tests.cloud_storage_timing_stress_test.CloudStorageTimingStressTest.test_cloud_storage.cleanup_policy=delete"
"rptest.tests.cloud_retention_test.CloudRetentionTest.test_cloud_retention.max_consume_rate_mb=None.cloud_storage_type=CloudStorageType.S3"

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Dec 22, 2023 •
edited

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43331#018c9382-6a65-45b9-aaa8-1746f03ab9f8

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43336#018c94aa-34b4-48c1-8760-f8791e2a60d3

@rockwotj
Copy link
Contributor Author

/ci-repeat

@rockwotj rockwotj merged commit 2d986c6 into redpanda-data:dev Jan 2, 2024
17 checks passed
@rockwotj rockwotj deleted the backport branch January 2, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvartolomei nvartolomei nvartolomei approved these changes

@gousteris gousteris Awaiting requested review from gousteris gousteris is a code owner automatically assigned from redpanda-data/devprod

@dotnwat dotnwat Awaiting requested review from dotnwat

Assignees
No one assigned
Labels
area/build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rockwotj @vbotbuildovich @dotnwat @nvartolomei