-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rm_stm: remove dead code #15924
Merged
Merged
rm_stm: remove dead code #15924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This map is never written to, after commit redpanda-data@d7fe6e7
No longer used after is_tx_ga = true
rockwotj
previously approved these changes
Jan 3, 2024
rockwotj
previously approved these changes
Jan 3, 2024
ztlpn
previously approved these changes
Jan 3, 2024
/ci-repeat 1 |
preparing is no longer a phase in the current tree.
bharathv
force-pushed
the
remove_expected
branch
from
January 4, 2024 23:21
a0eee43
to
5f3afdc
Compare
Rerunning the build after a force push that removed an extra argument in fmt string, will re-request reviews once the build is green. |
rockwotj
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mem_state::expected - This map is never written to, after commit
d7fe6e7
mem_state::tx_start(s) - Unused after is_tx_ga=true
mem_state::preparing - preparing phase is no longer used as a part of the protocol.
Backports Required
Release Notes