Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm_stm: remove dead code #15924

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Conversation

bharathv
Copy link
Contributor

@bharathv bharathv commented Jan 3, 2024

mem_state::expected - This map is never written to, after commit
d7fe6e7
mem_state::tx_start(s) - Unused after is_tx_ga=true
mem_state::preparing - preparing phase is no longer used as a part of the protocol.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

This map is never written to, after commit
redpanda-data@d7fe6e7
No longer used after is_tx_ga = true
rockwotj
rockwotj previously approved these changes Jan 3, 2024
@bharathv bharathv changed the title rm_stm: remove mem_state expected rm_stm: remove dead code Jan 3, 2024
@bharathv bharathv requested a review from rockwotj January 3, 2024 18:36
rockwotj
rockwotj previously approved these changes Jan 3, 2024
ztlpn
ztlpn previously approved these changes Jan 3, 2024
@bharathv
Copy link
Contributor Author

bharathv commented Jan 3, 2024

@mmaslankaprv
Copy link
Member

/ci-repeat 1

preparing is no longer a phase in the current tree.
@bharathv
Copy link
Contributor Author

bharathv commented Jan 4, 2024

Rerunning the build after a force push that removed an extra argument in fmt string, will re-request reviews once the build is green.

@bharathv bharathv merged commit 46c8cde into redpanda-data:dev Jan 5, 2024
19 checks passed
@bharathv bharathv deleted the remove_expected branch January 5, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants