net: Cache value of local address #15931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphcareful
requested review from
oleiman,
StephanDollberg and
michael-redpanda
emaxerrno
reviewed
Jan 3, 2024
michael-redpanda
previously approved these changes
Jan 3, 2024
StephanDollberg
previously approved these changes
Jan 4, 2024
There was a problem hiding this comment.
PR body and the commit say:
Fixes: #15898
That would close the issue but I think this commit only partially addresses a subset of the issues?
| @@ -133,6 +133,7 @@ connection::connection( | |||
| , _hook(hook) | |||
| , _name(std::move(name)) | |||
| , _fd(std::move(f)) | |||
| , _local_addr(_fd.local_address()) | |||
There was a problem hiding this comment.
Doing this always is fine I guess as most connections are kafka rpc connections so we will need this sooner than later anyway?
There was a problem hiding this comment.
The logic is that the local address will never change for the duration of the instance, therefore it is safe to cache
Removing the |
- Performance testing has shown excessive CPU time is spent when local_address() is called within a tight loop, this has been tracked down to the fact that ss::file_desc::local_address() invokes a system call, getsockname. - To mitigate this issue, the connection class now caches the value of local address upon instantiation. - Partially fixes: redpanda-data#15898
graphcareful
dismissed stale reviews from StephanDollberg and michael-redpanda
via
1cc1d1b
graphcareful
force-pushed
the
net-cache-localaddr
branch
from
9570cfa
to
1cc1d1b
Compare
michael-redpanda
approved these changes
Jan 4, 2024
|
Failure is #15893 |
|
/backport v23.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance testing has shown excessive CPU time is spent when local_address() is called within a tight loop, this has been tracked down to the fact that ss::file_desc::local_address() invokes a system call, getsockname.
To mitigate this issue, the connection class now caches the value of local address upon instantiation.
Relates to: audit logging perf overhead #15898
Backports Required
Release Notes
Improvements