build: introduce foundational base library #15968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds <module>/include path to includes directory when linking against a v::lib library, which is intended to be the pattern for exposing public headers from a module. The default include path of the root of the tree is also removed because it is currently handled in the root cmake file and will later be removed. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
The base library is a foundational library. The rough guidelines for determining if something belongs in the base library are: 1. It would be reasonable if every target depended on it (e.g. vlog.h). 2. It contains no dependencies on other Redpanda targets (e.g. utils). 3. Its external dependencies may also be considered foundational (e.g. seastar). Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
rockwotj
previously approved these changes
Jan 5, 2024
| @@ -0,0 +1,6 @@ | |||
| The base library is a foundational library. The rough guidelines for determining | |||
There was a problem hiding this comment.
I really like having READMEs in every module for documentation.
src/v/base/CMakeLists.txt
Outdated
| @@ -1 +1,7 @@ | |||
| v_cc_library(NAME base) | |||
|
|
|||
| rp_test( | |||
There was a problem hiding this comment.
Should this be in the standard tests directory?
There was a problem hiding this comment.
ah, yeh, thanks. will push an extra commit after we see if this things builds in CI
my second favorite webpage on the internet is https://blog.jasonmeridth.com/posts/use-git-grep-to-replace-strings-in-files-in-your-git-repository/ |
dotnwat
requested review from
savex,
bharathv,
ztlpn and
graphcareful
and removed request for
a team
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
graphcareful
approved these changes
Jan 5, 2024
rockwotj
approved these changes
Jan 5, 2024
savex
approved these changes
Jan 5, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43501#018cdbb1-6bcb-4476-84be-fddf645e81f8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base library is a foundational library. The rough guidelines for determining
if something belongs in the base library are:
Currently this includes things like seastarx.h, vlog.h, etc...
This is a necessary step towards header isolation, because we can no longer default include the root directory.
Backports Required
Release Notes