Introduced partition shutdown watchdog timer #16067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Maslanka <michal@redpanda.com>
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43670#018cf8de-ec3c-4a65-8df4-ae3fc71ed87a ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43714#018cfd8f-71dd-44b9-9425-bec94b464426 |
ztlpn
previously approved these changes
Jan 11, 2024
bharathv
reviewed
Jan 12, 2024
| @@ -101,6 +107,11 @@ partition_manager::get_topic_partition_table( | |||
| return rs; | |||
| } | |||
|
|
|||
| ss::future<> partition_manager::start() { | |||
| maybe_arm_shutdown_watchdog(); | |||
There was a problem hiding this comment.
nit: I think this is a good usecase for arm_periodic()
Introduced property that is going to be used by `cluster::partition_manager` shutdown watchdog mechanism. Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
shutdown-tracking
branch
2 times, most recently
from
1b7884a
to
f1cac93
Compare
Introduced a watchdog that is tracking partition shutdown state. The watchdog is intended to provide a mechanism that will ease debugging of partition shutdown issues. The watchdog tracks state of partitions that were requested to be stopped or removed. When there was no state update for the time longer than the configurable threshold (by default 30 seconds) the watchdog will emit error log entry which will inform user about the problem. Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
shutdown-tracking
branch
from
f1cac93
to
3adfdfc
Compare
ztlpn
approved these changes
Jan 12, 2024
|
/backport v23.3.x |
|
/backport v23.2.x |
|
Failed to create a backport PR to v23.3.x branch. I tried: |
|
Failed to create a backport PR to v23.2.x branch. I tried: |
This was referenced Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a watchdog that is tracking partition shutdown state. The
watchdog is intended to provide a mechanism that will ease debugging of
partition shutdown issues. The watchdog tracks state of partitions that
were requested to be stopped or removed. When there was no state update
for the time longer than the configurable threshold (by default 30
seconds) the watchdog will emit error log entry which will inform user
about the problem.
Backports Required
Release Notes