Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for CI Failure (Failed to make list_offsets request, unknown broker) in DeleteRecordsTest.test_delete_records_segment_deletion #16078

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Fix for CI Failure (Failed to make list_offsets request, unknown broker) in DeleteRecordsTest.test_delete_records_segment_deletion #16078

merged 1 commit into from
Jan 16, 2024

Conversation

graphcareful
Copy link
Contributor

@graphcareful graphcareful commented Jan 11, 2024 •
edited

  • The rpk consume single record test to verifiy a given offset has the exact same timeout as the retry logic that surrounds it.
  • This commit bumps the timeout so that the retry logic may actually be implemented.
  • Adding additional logs for debugging visibility

Link to underlying issue: #14641

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

rockwotj
rockwotj previously approved these changes Jan 12, 2024
View reviewed changes
tests/rptest/tests/delete_records_test.py Outdated Show resolved Hide resolved
@michael-redpanda
Copy link
Contributor

/dt

@graphcareful
Copy link
Contributor Author

/ci-repeat 3
skip-unit
dt-repeat=15
tests/rptest/tests/delete_records_test.py::DeleteRecordsTest.test_delete_records_segment_deletion

@graphcareful graphcareful marked this pull request as ready for review January 12, 2024 17:09
@graphcareful
Copy link
Contributor Author

/ci-repeat 3
skip-unit
dt-repeat=15
tests/rptest/tests/delete_records_test.py::DeleteRecordsTest.test_delete_records_segment_deletion

@graphcareful
rptest: Increase retry logic timer
0f14e46 
- The rpk consume single record test to verifiy a given offset has the
exact same timeout as the retry logic that surrounds it.

- This commit bumps the timeout so that the retry logic may actually be
implemented.

- Adding additional logs for debugging visibility
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jan 16, 2024 •
edited

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43784#018d0f9e-ee9e-4b7e-baa9-fe43f20df694

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43784#018d0f9e-eea4-477b-891a-6d6f6dd68cc0

oleiman
oleiman approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@graphcareful
Copy link
Contributor Author

/ci-repeat 3
skip-unit
dt-repeat=15
tests/rptest/tests/delete_records_test.py::DeleteRecordsTest.test_delete_records_segment_deletion

@graphcareful
Copy link
Contributor Author

/ci-repeat 1
skip-unit
dt-repeat=15
tests/rptest/tests/delete_records_test.py::DeleteRecordsTest.test_delete_records_segment_deletion

@graphcareful graphcareful merged commit 41b0a4f into redpanda-data:dev Jan 16, 2024
17 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@graphcareful graphcareful mentioned this pull request Jan 16, 2024
Closed
This was referenced Jan 16, 2024
Merged
Merged
@graphcareful graphcareful mentioned this pull request Jan 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleiman oleiman oleiman approved these changes

@michael-redpanda michael-redpanda michael-redpanda approved these changes

@rockwotj rockwotj rockwotj left review comments

Assignees

@graphcareful graphcareful

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@graphcareful @michael-redpanda @vbotbuildovich @oleiman @rockwotj