rpk: improve --exit-when-healthy in cluster health #16106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--exit-when-healthy flag only makes sense with the --watch flag, so we enable now --watch if --exit-when-healthy is set.
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43783#018d0f60-7349-4458-89f6-844cdd24c98b |
r-vasquez
force-pushed
the
improve-exit-when-healthy
branch
from
327d2e7
to
118408b
Compare
twmb
approved these changes
Jan 16, 2024
gene-redpanda
approved these changes
Jan 17, 2024
Deflaimun
reviewed
Jan 17, 2024
| @@ -65,7 +68,7 @@ following conditions are met: | |||
| p.InstallSASLFlags(cmd) | |||
|
|
|||
| cmd.Flags().BoolVarP(&watch, "watch", "w", false, "Blocks and writes out all cluster health changes") | |||
| cmd.Flags().BoolVarP(&exit, "exit-when-healthy", "e", false, "When used with watch, exits after cluster is back in healthy state") | |||
| cmd.Flags().BoolVarP(&exit, "exit-when-healthy", "e", false, "Exits after cluster is back in healthy state") | |||
There was a problem hiding this comment.
Suggested change
| cmd.Flags().BoolVarP(&exit, "exit-when-healthy", "e", false, "Exits after cluster is back in healthy state") | |
| cmd.Flags().BoolVarP(&exit, "exit-when-healthy", "e", false, "Exits after cluster is back in a healthy state") |
|
/backport v23.3.x |
This was referenced Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--exit-when-healthy flag only makes sense with the --watch flag, so we enable now --watch if --exit-when-healthy is set.
Fixes #15818
Backports Required
Release Notes
Improvements
--exit-when-healthyenables--watchwhen provided.