Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rptest: Wait for the group to be in a stable state before starting tests #16127

Merged
merged 1 commit into from
Jan 24, 2024
Merged

rptest: Wait for the group to be in a stable state before starting tests #16127

merged 1 commit into from
Jan 24, 2024

Conversation

graphcareful
Copy link
Contributor

@graphcareful graphcareful commented Jan 17, 2024 •
edited

  • Its been observed many times in the ConsumerGroupTests that an unbalanced consumer consumes all messages and and some type of assertion that expects at least all members to consume some records fails by way of timing out.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@graphcareful
rptest: Wait for Stable before start cgrups tests
c912d69 
- Its been observed many times in the ConsumerGroupTests that an
unbalanced consumer consumes all messages and and some type of assertion
that expects at least all members to consume some records fails by way
of timing out.
@graphcareful
Copy link
Contributor Author

graphcareful commented Jan 17, 2024 •
edited

Potential fix for #15302 #12142

@graphcareful
Copy link
Contributor Author

/ci-repeat 3
skip-units
dt-repeat=5
tests/rptest/tests/consumer_group_test.py::ConsumerGroupTest.test_consumer_is_removed_when_timedout

BenPope
BenPope reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@BenPope BenPope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@graphcareful
Copy link
Contributor Author

/ci-repeat 3
skip-unit
skip-redpanda-build
dt-repeat=50
tests/rptest/tests/consumer_group_test.py::ConsumerGroupTest.test_dead_group_recovery

@graphcareful graphcareful marked this pull request as ready for review January 18, 2024 17:00
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jan 18, 2024 •
edited

new failures in https://buildkite.com/redpanda/redpanda/builds/43900#018d1dc3-571b-4f25-89c5-89ea9e4b1f81:

"rptest.tests.cloud_storage_timing_stress_test.CloudStorageTimingStressTest.test_cloud_storage.cleanup_policy=delete"

new failures in https://buildkite.com/redpanda/redpanda/builds/43900#018d1dc3-5715-437e-a79c-6c04692dbefe:

"rptest.tests.cloud_storage_timing_stress_test.CloudStorageTimingStressTest.test_cloud_storage_with_partition_moves.cleanup_policy=delete"

@graphcareful
Copy link
Contributor Author

/ci-repeat 3
skip-unit
skip-redpanda-build
dt-repeat=50
tests/rptest/tests/consumer_group_test.py::ConsumerGroupTest.test_dead_group_recovery

michael-redpanda
michael-redpanda approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@michael-redpanda michael-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michael-redpanda michael-redpanda merged commit 8ba0079 into redpanda-data:dev Jan 24, 2024
19 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich vbotbuildovich mentioned this pull request Jan 24, 2024
Merged
@graphcareful
Copy link
Contributor Author

/backport v23.2.x

@vbotbuildovich vbotbuildovich mentioned this pull request Jan 24, 2024
Merged
@michael-redpanda michael-redpanda mentioned this pull request Jan 26, 2024
Closed
@graphcareful graphcareful mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenPope BenPope BenPope left review comments

@michael-redpanda michael-redpanda michael-redpanda approved these changes

@dotnwat dotnwat Awaiting requested review from dotnwat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@graphcareful @vbotbuildovich @BenPope @michael-redpanda