rptest: invalid comparison in test_max_connections #16133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We comared a list to a float, which will fail at runtime. Presumably we don't hit this case when the test passes but we can hit it for some failures. This bug was found through typing.
travisdowns
commented
Jan 17, 2024
| @@ -604,7 +604,7 @@ def swarm_start(node): | |||
| if (len(swarm) - calc_alive_swarm_nodes(swarm)) > 1: | |||
| break | |||
| elif _elapsed > FINISH_TIMEOUT_SEC and \ | |||
| _connections < (self._advertised_max_client_count * 0.01): | |||
There was a problem hiding this comment.
_connections is a list (this used to work, but _connections type was changed at some point), _total is the sum of all values in connections and is the correct lhs for this test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We comared a list to a float, which will fail at runtime. Presumably we don't hit this case when the test passes but we can hit it for some failures.
This bug was found through typing.
Backports Required
Release Notes