Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix flink install on ARM64 #16135

Merged
merged 1 commit into from
Jan 18, 2024
Merged

ci: Fix flink install on ARM64 #16135

merged 1 commit into from
Jan 18, 2024

Conversation

savex
Copy link
Contributor

@savex savex commented Jan 17, 2024

For ARM64 architecture JAVA_HOME env var is empty for some reason.
Flink installation expects it. Safety wise, no checking of arch, and extracting JAVA_HOME from java app itself if target var is empty

Fixes: redpanda-data/devprod#1015

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@savex savex self-assigned this Jan 17, 2024
@savex savex marked this pull request as ready for review January 17, 2024 18:43
@savex savex requested a review from a team as a code owner January 17, 2024 18:43
@savex savex requested review from gousteris and removed request for a team January 17, 2024 18:43
@savex
Copy link
Contributor Author

savex commented Jan 17, 2024

/cdt
cdt_arch=arm64
rp_repo=nightly
rp_version=latest

@savex
Copy link
Contributor Author

savex commented Jan 17, 2024

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jan 17, 2024

@savex
Copy link
Contributor Author

savex commented Jan 18, 2024

/cdt
cdt_arch=arm64

@gousteris
Copy link
Contributor

/cdt
rp_repo=nightly
rp_version=latest
cdt_arch=arm64
ducktape_deps_git_version=15caae2c9fd9345cc98de9a898b774da76964f0d

Copy link
Contributor

@gousteris gousteris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that cdt fails for nightly and ci packages.

I triggered cdt on nightly and set the ducktape deps version to the HEAD of this branch: https://buildkite.com/redpanda/redpanda/builds/43887

Copy link
Contributor

@gousteris gousteris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we backport this to 23.3? the flink dependencies exist there https://github.com/redpanda-data/redpanda/blob/v23.3.x/tests/docker/ducktape-deps/flink

@savex
Copy link
Contributor Author

savex commented Jan 18, 2024

Updated back port list

@savex savex merged commit cf46a28 into dev Jan 18, 2024
20 of 22 checks passed
@savex savex deleted the dp-1015-fix-java-home-arm64 branch January 18, 2024 16:24
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.3.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-16135-v23.3.x-746 remotes/upstream/v23.3.x
git cherry-pick -x 15caae2c9fd9345cc98de9a898b774da76964f0d

Workflow run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants