Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMBSampleConfigurations predicates are static #16136

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

travisdowns
Copy link
Member

The predicates in OMBSampleConfigurations are static methods but are not marked as such.

This bug was detected by typing.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

The predicates in OMBSampleConfigurations are static methods but are
not marked as such.

This error was detected by typing.
@travisdowns travisdowns requested review from ballard26 and andrewhsu and removed request for ballard26 January 17, 2024 19:00
Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbotbuildovich
Copy link
Collaborator

@travisdowns travisdowns merged commit bd81df6 into redpanda-data:dev Jan 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants