Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduling_groups: report cpu usage for all cores #16154

Merged
merged 1 commit into from
Jan 20, 2024
Merged

scheduling_groups: report cpu usage for all cores #16154

merged 1 commit into from
Jan 20, 2024

Conversation

rockwotj
Copy link
Contributor

@rockwotj rockwotj commented Jan 18, 2024 •
edited

Currently we only report the breakdown by scheduling group for core 0, it's probably useful for all cores.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

Bug Fixes

  • Report runtime public metrics by task queue for all cores, not just core 0

@rockwotj
Copy link
Contributor Author

Force push rebase to conflicts.

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jan 19, 2024 •
edited

new failures in https://buildkite.com/redpanda/redpanda/builds/43920#018d1f90-eb32-4b1e-aca2-1b0a59556be7:

"rptest.tests.idempotency_test.IdempotencySnapshotDelivery.test_recovery_after_snapshot_is_delivered"

new failures in https://buildkite.com/redpanda/redpanda/builds/43920#018d1f8b-5730-4b1b-8557-ea8c1b3e9a1a:

"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.ABS"

new failures in https://buildkite.com/redpanda/redpanda/builds/43966#018d22d5-0077-4be4-b4cc-f7819a98fdcb:

"rptest.tests.tiered_storage_model_test.TieredStorageTest.test_tiered_storage.cloud_storage_type=CloudStorageType.ABS.test_case=.TS_Read==True.AdjacentSegmentMergerReupload==True"

new failures in https://buildkite.com/redpanda/redpanda/builds/43966#018d22e3-62f4-4ae8-b569-a31bf124b1e3:

"rptest.tests.cloud_storage_timing_stress_test.CloudStorageTimingStressTest.test_cloud_storage_with_partition_moves.cleanup_policy=delete"

new failures in https://buildkite.com/redpanda/redpanda/builds/43966#018d22e3-62fa-4677-9aaf-d87e7853adf1:

"rptest.tests.archive_retention_test.CloudArchiveRetentionTest.test_delete.cloud_storage_type=CloudStorageType.ABS.retention_type=retention.bytes"

@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43920#018d1f8b-572c-4416-9b85-3f9cbbd7cecd

StephanDollberg
StephanDollberg previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@StephanDollberg StephanDollberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, think commit message should make clear this is about public metrics though

BenPope
BenPope previously approved these changes Jan 19, 2024
View reviewed changes
@rockwotj rockwotj force-pushed the scheduling_groups branch 2 times, most recently from 1a918cb to 769deab Compare January 19, 2024 14:34
@rockwotj rockwotj requested a review from a team as a code owner January 19, 2024 14:34
@rockwotj rockwotj requested review from savex and removed request for a team January 19, 2024 14:34
@rockwotj
scheduling_groups: add public metrics for all cores
8ea1ff4 
Currently we only report the breakdown by scheduling group for core 0 in
public metrics.

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj rockwotj dismissed stale reviews from StephanDollberg and BenPope January 19, 2024 14:34

The merge-base changed after approval.

@rockwotj
Copy link
Contributor Author

Force pushes: rebase against dev and fix commit message - no code changes

@rockwotj
Copy link
Contributor Author

CI Failures: #16026, #13841, and #14445

@rockwotj rockwotj merged commit 261526d into redpanda-data:dev Jan 20, 2024
18 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.1.x

@rockwotj rockwotj deleted the scheduling_groups branch January 20, 2024 01:54
@vbotbuildovich vbotbuildovich mentioned this pull request Jan 20, 2024
Merged
@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-16154-v23.2.x-964 remotes/upstream/v23.2.x
git cherry-pick -x 8ea1ff4fcdb4e28cd7d73c06457066e7df5c0424

Workflow run logs.

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.1.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-16154-v23.1.x-580 remotes/upstream/v23.1.x
git cherry-pick -x 8ea1ff4fcdb4e28cd7d73c06457066e7df5c0424

Workflow run logs.

This was referenced Jan 20, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanDollberg StephanDollberg StephanDollberg approved these changes

@travisdowns travisdowns Awaiting requested review from travisdowns

@savex savex Awaiting requested review from savex savex was automatically assigned from redpanda-data/devprod

@BenPope BenPope Awaiting requested review from BenPope

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rockwotj @vbotbuildovich @BenPope @StephanDollberg