Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change metrics to match generate_charts.py #16158

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

ballard26
Copy link
Contributor

generate_charts.py takes the min of the publishLatencyMin and endToEndLatencyMin metrics in result.json. See https://github.com/redpanda-data/openmessaging-benchmark/blob/main/bin/generate_charts.py#L300 . Our validators for OMB results expect a single value for these metrics as well and not the list of values present in result.json. This PR changes our metrics validator to match this behavior and makes publishLatencyMin and endToEndLatencyMin a single value that is the min of their lists in result.json

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@ballard26 ballard26 merged commit 18e519b into redpanda-data:dev Jan 19, 2024
18 checks passed
@ballard26 ballard26 deleted the omb-nightly-fix branch January 19, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants