Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk/transform/init: fix rust template #16180

Merged
merged 1 commit into from
Jan 19, 2024
Merged

rpk/transform/init: fix rust template #16180

merged 1 commit into from
Jan 19, 2024

Conversation

rockwotj
Copy link
Contributor

The wrong Error import was used, and we need to specify the error type
as we don't import anyhow for users.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

Bug Fixes

  • Fix the starter code for Rust projects in rpk transform init

@rockwotj
rpk/transform/init: fix rust template
d6ac89d 
The wrong Error import was used, and we need to specify the error type
as we don't import anyhow for users.

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
oleiman
oleiman approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jan 19, 2024 •
edited

new failures in https://buildkite.com/redpanda/redpanda/builds/43968#018d22db-2c42-4df6-99fb-9f6c871d820b:

"rptest.tests.cloud_storage_timing_stress_test.CloudStorageTimingStressTest.test_cloud_storage_with_partition_moves.cleanup_policy=delete"

new failures in https://buildkite.com/redpanda/redpanda/builds/43968#018d236a-d950-48b6-92b4-45c991e39f66:

"rptest.tests.cloud_storage_timing_stress_test.CloudStorageTimingStressTest.test_cloud_storage_with_partition_moves.cleanup_policy=delete"

@rockwotj
Copy link
Contributor Author

CI Failure: #16026 is persistent

@piyushredpanda piyushredpanda merged commit faa6113 into redpanda-data:dev Jan 19, 2024
22 of 24 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich vbotbuildovich mentioned this pull request Jan 19, 2024
Merged
@rockwotj rockwotj deleted the rust-tmpl branch January 19, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleiman oleiman oleiman approved these changes

@twmb twmb Awaiting requested review from twmb twmb is a code owner

@r-vasquez r-vasquez Awaiting requested review from r-vasquez r-vasquez is a code owner

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda gene-redpanda is a code owner

@michael-redpanda michael-redpanda Awaiting requested review from michael-redpanda

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rockwotj @vbotbuildovich @oleiman @piyushredpanda