-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin/server: fix get_cluster_id response formatting #16183
Conversation
new failures in https://buildkite.com/redpanda/redpanda/builds/43975#018d2311-24e7-4719-b859-5b1d9cd4b288:
|
issue is #16036 in dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should have a test that checks the output format since this is an external facing interface?
interestingly in cluster_manifest.json we correctly unwrap uuid. here redpanda/tests/rptest/tests/cluster_metadata_upload_test.py Lines 156 to 165 in 0afd0bd
we compare the uuid from a cluster_manifest.json against the response from admin API by doing orig_cluster_uuid in orig_cluster_uuid_resp instead of orig_cluster_uuid == orig_cluster_uuid_resp so that test was coded to be resilient. i'm adding a ducktape test
|
eb23839
to
5cdc346
Compare
5cdc346
to
c60e79a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/backport v23.3.x |
/backport v23.3.x |
Unwrap the cluster_uuid_t type when formatting the response
Fixes #16162
Backports Required
Release Notes
Improvements