Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archival: apply PR feedback #16189

Merged
merged 3 commits into from
Jan 22, 2024
Merged

archival: apply PR feedback #16189

merged 3 commits into from
Jan 22, 2024

Conversation

dotnwat
Copy link
Member

@dotnwat dotnwat commented Jan 19, 2024 •
edited

Apply feedback from PR review.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@dotnwat
cluster: use auto type
ad0f1c1 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
cluster: use std::copy_if helper
8e4155d 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat
chore: apply clang format
ee00b49 
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
@dotnwat dotnwat changed the title Seg manifest oom archival: apply PR feedback Jan 19, 2024
@dotnwat dotnwat mentioned this pull request Jan 19, 2024
Merged
7 tasks
@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/43982#018d237b-8d2b-4db9-87b2-85a2ada36cfd:

"rptest.tests.cloud_storage_timing_stress_test.CloudStorageTimingStressTest.test_cloud_storage.cleanup_policy=delete"

@dotnwat
Copy link
Member Author

dotnwat commented Jan 22, 2024

Failure is this. It's a different test but same underlying problem. #16026

@dotnwat dotnwat merged commit 821bd6d into redpanda-data:dev Jan 22, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhijat abhijat abhijat approved these changes

@andrwng andrwng andrwng approved these changes

@Lazin Lazin Awaiting requested review from Lazin

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotnwat @vbotbuildovich @abhijat @andrwng