Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ducktape: fix flink URL 404 #16234

Merged
merged 2 commits into from
Jan 24, 2024
Merged

ducktape: fix flink URL 404 #16234

merged 2 commits into from
Jan 24, 2024

Conversation

bharathv
Copy link
Contributor

Current URL throws a 404 and 1.18.0 is not hosted anywhere. Also switching the download URL as per
apache/flink-docker#170

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@bharathv bharathv requested a review from a team as a code owner January 23, 2024 04:00
@bharathv bharathv requested review from savex and removed request for a team January 23, 2024 04:00
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jan 23, 2024 •
edited

new failures in https://buildkite.com/redpanda/redpanda/builds/44128#018d34a9-4166-4d0b-a7f4-e778ab207d15:

"rptest.tests.flink_basic_test.FlinkBasicTests.test_transaction_workload"

new failures in https://buildkite.com/redpanda/redpanda/builds/44128#018d34ba-e4d7-48d9-a702-95770503f003:

"rptest.tests.flink_basic_test.FlinkBasicTests.test_transaction_workload"

new failures in https://buildkite.com/redpanda/redpanda/builds/44160#018d3733-6dec-4310-8aa8-38e0ac517962:

"rptest.tests.flink_basic_test.FlinkBasicTests.test_transaction_workload"

new failures in https://buildkite.com/redpanda/redpanda/builds/44160#018d3750-57c3-4f54-894a-9fe53a38579c:

"rptest.tests.flink_basic_test.FlinkBasicTests.test_transaction_workload"

new failures in https://buildkite.com/redpanda/redpanda/builds/44160#018d37b5-8072-4ad3-9b4a-a3e31307f7df:

"rptest.tests.flink_basic_test.FlinkBasicTests.test_transaction_workload"

new failures in https://buildkite.com/redpanda/redpanda/builds/44160#018d37b5-7127-472a-921a-a433c726b2a9:

"rptest.tests.flink_basic_test.FlinkBasicTests.test_transaction_workload"

savex
savex previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@savex savex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green build.
Also, we will discuss internally on putting flink binary somewhere not to hit the same issue again.

@savex savex self-requested a review January 23, 2024 14:40
savex
savex previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@savex savex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on dev

@savex
Copy link
Contributor

savex commented Jan 23, 2024

@bharathv, if you do not mind I will use this PR to update links to our internal binary storage after internal discussion to eliminate similar situation in future.

andrewhsu
andrewhsu reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@andrewhsu andrewhsu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't recommend using archive because file size is ~450M and archive sets limit

40 GB downloaded per week

@savex savex requested a review from andrewhsu January 23, 2024 16:05
@savex
Copy link
Contributor

savex commented Jan 23, 2024

Updated to S3.
Verified docker container build locally.

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jan 23, 2024 •
edited

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44160#018d3733-6df2-4a2b-996b-51fe7b4882e4

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44160#018d3733-6dec-4310-8aa8-38e0ac517962

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44172#018d3827-8376-4bcc-af21-f23c9d8163c9

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44229#018d3d01-89a0-48cf-a7e5-2664d2b84eb5

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44229#018d3d13-c4b0-4ae2-a709-e8b1e6faa2ef

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44229#018d3d13-c4b6-4840-bd1c-41cb9335756d

andrewhsu
andrewhsu previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@savex
Copy link
Contributor

savex commented Jan 23, 2024

/ci-repeat

@savex savex self-requested a review January 24, 2024 00:11
savex
savex previously approved these changes Jan 24, 2024
View reviewed changes
bharathv and others added 2 commits January 24, 2024 12:30
@bharathv @savex
ducktape: fix flink URL
a452101 
Current URL throws a 404 and 1.18.0 is not hosted anywhere.
Also switching the download URL as per
apache/flink-docker#170

ci: Update flink link to archive.apache.org
@savex
ci: Update flink deps to use S3
fb0903d 
ci: Fix comment section.
@savex savex self-requested a review January 24, 2024 18:31
savex
savex approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@savex savex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, checked yesterday. This is a cleaned up and rebased version.

@savex savex merged commit cc6bae5 into redpanda-data:dev Jan 24, 2024
16 checks passed
@BenPope
Copy link
Member

BenPope commented Jan 25, 2024

/backport v23.3.x

@vbotbuildovich vbotbuildovich mentioned this pull request Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savex savex savex approved these changes

@andrewhsu andrewhsu andrewhsu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bharathv @vbotbuildovich @savex @BenPope @andrewhsu