-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v23.2.x] c/topics_dispatcher: do not guesstimate leader ids #16239
[v23.2.x] c/topics_dispatcher: do not guesstimate leader ids #16239
Commits on Jan 23, 2024
-
c/topics_dispatcher: do not guesstimate leader ids
Updating leadership metadata before the topic is ready to serve traffic is not desired. It prevents waiting for leader to be reported by raft group when it is actually ready. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 3e86234)
Configuration menu - View commit details
-
Copy full SHA for 2fb8291 - Browse repository at this point
Copy the full SHA 2fb8291View commit details -
leaders_table: removed unused method to estimate leaders
Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 8f81843)
Configuration menu - View commit details
-
Copy full SHA for a98e90a - Browse repository at this point
Copy the full SHA a98e90aView commit details -
k/metadata: do not return no leader when leader is not yet available
Instead of returning `-1` indicating that there is an ongoing leader election we return randomly selected node as a partition leader. This is much less interrupting for the client as it simply forces it to refresh metadata. Some clients do not tolerate `-1` returned from Metadata handler and simply stop working. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 86d583b)
Configuration menu - View commit details
-
Copy full SHA for 2b39dd6 - Browse repository at this point
Copy the full SHA 2b39dd6View commit details
Commits on Jan 24, 2024
-
tests: wait for all leaders in force reconfiguration test
Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 763c0ac)
Configuration menu - View commit details
-
Copy full SHA for 6d67074 - Browse repository at this point
Copy the full SHA 6d67074View commit details -
tests: added more logging to metadata dissemination test
Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 5bf2a27)
Configuration menu - View commit details
-
Copy full SHA for ae0fdd8 - Browse repository at this point
Copy the full SHA ae0fdd8View commit details -
tests: increased timeout in metadata dissemination test
The metadata dissemination test must account for exponential backoff which may be longer than used 10 seconds timeout. Now as we do not update leaders table after topic create command is applied we need to wait for the request to be delivered to joining node. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit fea4f6a)
Configuration menu - View commit details
-
Copy full SHA for b9beb7d - Browse repository at this point
Copy the full SHA b9beb7dView commit details -
tests: disable leadership balancer in cg recovery test
The consumer group recovery test doesn't do any validation if offset listing was successful. Disabling leader balancer will make the test more stable before we introduce validation in recovery tool (now the tool assumes that user is going to review offsets listing). Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 3b2eac5)
Configuration menu - View commit details
-
Copy full SHA for 7f884b1 - Browse repository at this point
Copy the full SHA 7f884b1View commit details -
tests: wait for acks in upgrade test
Wait for at least some of the messages to be successfully written to topic before starting consumers to prevent them trying to read empty partition. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 6823527)
Configuration menu - View commit details
-
Copy full SHA for ecd4030 - Browse repository at this point
Copy the full SHA ecd4030View commit details -
k/metadata: guesstimate leader when information is not yet present
When partition is first created in Redpanda some of the cluster nodes which are not hosting partition replicas may not yet have leadership metadata. In this case Redpanda still has to return partition metadata. In order not to disturb the client (returning -1 as a leader id may cause some clients to stop) Redpanda has to return a leader id. If the information is not present we will always return the first node from replica set in leader epoch equal to 0. This way client will either communicate with the actual leader or issue a metadata request to other node that may contain up to date information. Fixes: redpanda-data#15949 Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 7a60b75)
Configuration menu - View commit details
-
Copy full SHA for 5f13a37 - Browse repository at this point
Copy the full SHA 5f13a37View commit details