Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the request context fixture code work with produce requests #16244

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Make the request context fixture code work with produce requests #16244

merged 2 commits into from
Jan 31, 2024

Conversation

mfleming
Copy link
Contributor

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x
  • v23.1.x

Release Notes

  • none

@mfleming mfleming marked this pull request as ready for review January 23, 2024 12:55
@mfleming
tests: Rename make_request_context() since it's fetch specific
085ce6c 
In preparation for being able to make produce contexts, rename
make_request_context() so that it's more descriptive and reflects the
fact that it only works with fetch requests.
@mfleming
tests: Remove fetch specifics from make_request_context()
d4122e5 
Make make_request_context() a function template so that it can also be
used for produce requests.
@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/44294#018d4144-2e05-427c-b7d5-22dff4b75a53:

"rptest.tests.offset_for_leader_epoch_test.OffsetForLeaderEpochTest.test_offset_for_leader_epoch"

@mfleming mfleming merged commit 67befc1 into redpanda-data:dev Jan 31, 2024
17 checks passed
@mfleming mfleming deleted the pr/15363 branch January 31, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanDollberg StephanDollberg StephanDollberg approved these changes

@travisdowns travisdowns Awaiting requested review from travisdowns

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mfleming @vbotbuildovich @StephanDollberg